Repository navigation
Restore propagation when handing pyprep's logging output back - #219
Merged
Merged
Conversation
Clearing the handlers after setup_logging left propagate False, so records never reached the application's handlers again: INFO was dropped and warnings fell back to logging.lastResort.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 8 8
Lines 890 890
=======================================
Hits 873 873
Misses 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
The Notes of
pyprep.setup_loggingsaid to hand the output back by clearing the handlers of thepypreplogger.setup_loggingsetspropagate = False, and that stayed in place, so the application's handlers never received pyprep's records again:"INFO"was dropped and warnings fell back tologging.lastResort. The Notes now also setpropagate = True, and mention that clearing removes any handler the application attached to thepypreplogger.Tested locally: with the old recipe an application's root handler receives nothing; with the new one it receives
"INFO"and warnings again.tests/test_logging.pypasses and the docstring renders through numpydoc without warnings.Merge Checklist
closes #<issue-number>to automatically close an issueCITATION.cfffile